Skip to content

Fix type cast using 'whereType' instead of 'as' operator #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix type cast using 'whereType' instead of 'as' operator #73

wants to merge 1 commit into from

Conversation

@bikcrum
Copy link

@bikcrum bikcrum commented May 27, 2021

Description

This is the minimal fix for typecasting error caused in null safety mode.

Implementation:

Issue:

<Widget?>[....].where((a) => a != null).toList() as List<Widget>

// causes type 'List<Widget?>' is not a subtype of type 'List<Widget>' in type cast

Fix:

<Widget?>[....].where((a) => a != null).whereType<Widget>().toList()

Effective line numbers: [435-437], [600-620]

Related Issues

#69 #70 #71 #72

@mqhamdam mqhamdam mentioned this pull request Jul 15, 2021
Open
@housecode
Copy link

housecode commented Jul 29, 2021

is it ready to use at production ?

@definitelyme
Copy link

definitelyme commented Oct 23, 2021 •
edited
Loading

@Dn-a can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ineffablesam ineffablesam ineffablesam approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bikcrum @housecode @definitelyme @ineffablesam